[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230621172052.1499919-5-linan666@huaweicloud.com>
Date: Thu, 22 Jun 2023 01:20:52 +0800
From: linan666@...weicloud.com
To: axboe@...nel.dk, linan122@...wei.com, dan.j.williams@...el.com,
vishal.l.verma@...el.com
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
yukuai3@...wei.com, yi.zhang@...wei.com, houtao1@...wei.com,
yangerkun@...wei.com
Subject: [PATCH v3 4/4] block/badblocks: fix the bug of reverse order
From: Li Nan <linan122@...wei.com>
Order of badblocks will be reversed if we set a large area at once. 'hi'
remains unchanged while adding continuous badblocks is wrong, the next
setting is greater than 'hi', it should be added to the next position.
Let 'hi' +1 each cycle.
# echo 0 2048 > bad_blocks
# cat bad_blocks
1536 512
1024 512
512 512
0 512
Fixes: 9e0e252a048b ("badblocks: Add core badblock management code")
Signed-off-by: Li Nan <linan122@...wei.com>
---
block/badblocks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/badblocks.c b/block/badblocks.c
index 2c2ef8284a3f..3b816690b940 100644
--- a/block/badblocks.c
+++ b/block/badblocks.c
@@ -301,6 +301,7 @@ int badblocks_set(struct badblocks *bb, sector_t s, int sectors,
p[hi] = BB_MAKE(s, this_sectors, acknowledged);
sectors -= this_sectors;
s += this_sectors;
+ hi++;
changed = true;
}
}
--
2.39.2
Powered by blists - more mailing lists