[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0db4a705-10d0-93ce-df61-1a20d6d09959@collabora.com>
Date: Wed, 21 Jun 2023 12:00:09 +0200
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Shawn Sung (宋孝謙)
<Shawn.Sung@...iatek.com>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
Singo Chang (張興國)
<Singo.Chang@...iatek.com>,
Jason-JH Lin (林睿祥)
<Jason-JH.Lin@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 13/14] drm/mediatek: Sort OVL adaptor components in
alphabetical order
Il 21/06/23 11:16, Shawn Sung (宋孝謙) ha scritto:
> On Wed, 2023-06-21 at 10:16 +0200, AngeloGioacchino Del Regno wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>> Il 21/06/23 05:19, Hsiao Chien Sung ha scritto:
>>> - Rename OVL_ADAPTOR_TYPE_RDMA to OVL_ADAPTOR_TYPE_MDP_RDMA
>>> to align the naming rule of mtk_ovl_adaptor_comp_id.
>>> - Sort components' names in alphabetical order
>>> - Sort device table in alphabetical order
>>> - Add sentinel to device table
>>>
>>> Signed-off-by: Hsiao Chien Sung <shawn.sung@...iatek.com>
>>
>> I agree, but this commit should come before [12/14] of this series.
>
> Got it. Since [12/14] removed many lines that use component ID/type
> (for example, in mtk_ovl_adaptor_clk_enable() or
> mtk_ovl_adaptor_add_comp()), if this commit has to move before that,
> should I still modify them and delete them in [12/14]? Thanks.
>
Every commit has to work on its own, so you first perform the renaming in
one commit, then you modify and delete.
>>
>> Regards,
>> Angelo
>>
>
> Best regards,
> Hsiao Chien Sung
Powered by blists - more mailing lists