linux-kernel - Re: [PATCH] soc: ti: k3-ringacc: Fixup documentation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88587e16-8517-bd02-1ce5-7437ce288cb6@infradead.org>
Date:   Tue, 20 Jun 2023 19:27:34 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Nishanth Menon <nm@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Tero Kristo <kristo@...nel.org>
Cc:     vigneshr@...com, praneeth@...com, u-kumar1@...com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Peter Ujfalusi <peter.ujfalusi@...il.com>
Subject: Re: [PATCH] soc: ti: k3-ringacc: Fixup documentation errors



On 6/20/23 19:24, Nishanth Menon wrote:
> Fixup couple of misses in documentation. This squashes the following
> warnings:
> drivers/soc/ti/k3-ringacc.c:135: warning: Function parameter or member 'tdown_complete' not described in 'k3_ring_state'
> drivers/soc/ti/k3-ringacc.c:238: warning: expecting prototype for struct k3_ringacc. Prototype was for struct k3_ringacc_soc_data instead
> 
> Cc: Peter Ujfalusi <peter.ujfalusi@...il.com>
> Signed-off-by: Nishanth Menon <nm@...com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

(more below)

> ---
>  drivers/soc/ti/k3-ringacc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c
> index 8f131368a758..548b9f605d86 100644
> --- a/drivers/soc/ti/k3-ringacc.c
> +++ b/drivers/soc/ti/k3-ringacc.c
> @@ -125,6 +125,7 @@ struct k3_ring_ops {
>   * @occ: Occupancy
>   * @windex: Write index
>   * @rindex: Read index
> + * @tdown_complete: Tear down complete state
>   */
>  struct k3_ring_state {
>  	u32 free;
> @@ -229,7 +230,7 @@ struct k3_ringacc {
>  };
>  
>  /**
> - * struct k3_ringacc - Rings accelerator SoC data
> + * struct k3_ringacc_soc_data - Rings accelerator SoC data
>   *
>   * @dma_ring_reset_quirk:  DMA reset w/a enable

What does "w/a" mean?

>   */

Thanks.
-- 
~Randy