linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8450: add missing power-domains property to usb qmpphy node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6180134a-2919-0f13-e37c-bb64b6403692@linaro.org>
Date:   Wed, 21 Jun 2023 12:39:40 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450: add missing power-domains
 property to usb qmpphy node

Hi,

On 21/06/2023 12:01, Konrad Dybcio wrote:
> On 21.06.2023 11:55, Neil Armstrong wrote:
>> Add the missing property to fix the bindings check error:
>> arch/arm64/boot/dts/qcom/sm8450-hdk.dtb: phy@...8000: 'power-domains' is a required property
>>      From schema: Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>> ---
> Are you sure about this one? Historically PHYs have had their own GDSCs.
> 
> May just be a wrong binding fwiw

Indeed you're right, forget this patch USB30_PRIM_GDSC id for the controller
and starting from SM8550 a new one is used USB3_PHY_GDSC.

I'll fix the bindings.

Neil

> 
> Konrad
>>   arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 5cd7296c7660..f921bd520e40 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -2046,6 +2046,8 @@ usb_1_qmpphy: phy@...8000 {
>>   				 <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
>>   			clock-names = "aux", "ref", "com_aux", "usb3_pipe";
>>   
>> +			power-domains = <&gcc USB30_PRIM_GDSC>;
>> +
>>   			resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
>>   				 <&gcc GCC_USB3_PHY_PRIM_BCR>;
>>   			reset-names = "phy", "common";
>>
>> ---
>> base-commit: 15e71592dbae49a674429c618a10401d7f992ac3
>> change-id: 20230621-topic-sm8450-upstream-usb-phy-missing-power-domains-499a3d6c725f
>>
>> Best regards,