[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2d9f894c-39aa-ec45-78f7-a11ac980bb62@yandex.ru>
Date: Wed, 21 Jun 2023 16:22:32 +0500
From: stsp <stsp2@...dex.ru>
To: Jeff Layton <jlayton@...nel.org>, linux-kernel@...r.kernel.org
Cc: Chuck Lever <chuck.lever@...cle.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
Christian Brauner <brauner@...nel.org>,
linux-fsdevel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH 2/3] fd/locks: allow get the lock owner by F_OFD_GETLK
21.06.2023 16:05, Jeff Layton пишет:
> Yes. Ambiguous answers are worse than none at all.
But same for read locks, when you
query them with F_OFD_GETLK.
It doesn't sound ambiguous to me,
you get the valid owner, and you can
iterate them if you kill them in a
process (same as for read locks).
> What problem are you trying to solve by having F_OFD_GETLK report a pid?
Just a way to abruptly kill offending lockers,
as that most likely means the process hanged
(I have a 3rd party code that drives the locking,
so it can't be trusted not to hang).
Its not essential though, for sure.
Curiosity also plays the role here. :)
Though if you don't want, I can as well
not add a TODO comment to the code.
Powered by blists - more mailing lists