linux-kernel - Re: [RFC PATCH v8 04/10] dpll: netlink: Add DPLL framework base functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJL2HUkAtHEw5rq+@nanopsycho>
Date:   Wed, 21 Jun 2023 15:07:41 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Petr Oros <poros@...hat.com>
Cc:     Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
        kuba@...nel.org, vadfed@...a.com, jonathan.lemon@...il.com,
        pabeni@...hat.com, corbet@....net, davem@...emloft.net,
        edumazet@...gle.com, vadfed@...com, jesse.brandeburg@...el.com,
        anthony.l.nguyen@...el.com, saeedm@...dia.com, leon@...nel.org,
        richardcochran@...il.com, sj@...nel.org, javierm@...hat.com,
        ricardo.canuelo@...labora.com, mst@...hat.com, tzimmermann@...e.de,
        michal.michalik@...el.com, gregkh@...uxfoundation.org,
        jacek.lawrynowicz@...ux.intel.com, airlied@...hat.com,
        ogabbay@...nel.org, arnd@...db.de, nipun.gupta@....com,
        axboe@...nel.dk, linux@...y.sk, masahiroy@...nel.org,
        benjamin.tissoires@...hat.com, geert+renesas@...der.be,
        milena.olech@...el.com, kuniyu@...zon.com, liuhangbin@...il.com,
        hkallweit1@...il.com, andy.ren@...cruise.com, razor@...ckwall.org,
        idosch@...dia.com, lucien.xin@...il.com, nicolas.dichtel@...nd.com,
        phil@....cc, claudiajkang@...il.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, mschmidt@...hat.com,
        linux-clk@...r.kernel.org, vadim.fedorenko@...ux.dev
Subject: Re: [RFC PATCH v8 04/10] dpll: netlink: Add DPLL framework base
 functions

Wed, Jun 21, 2023 at 01:53:24PM CEST, jiri@...nulli.us wrote:
>Wed, Jun 21, 2023 at 01:18:59PM CEST, poros@...hat.com wrote:
>>Arkadiusz Kubalewski píše v Pá 09. 06. 2023 v 14:18 +0200:
>>> From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
>
>[...]
>
>Could you perhaps cut out the text you don't comment? Saves some time
>finding your reply.
>
>
>>> +static int
>>> +dpll_set_from_nlattr(struct dpll_device *dpll, struct genl_info
>>> *info)
>>> +{
>>> +       const struct dpll_device_ops *ops = dpll_device_ops(dpll);
>>> +       struct nlattr *tb[DPLL_A_MAX + 1];
>>> +       int ret = 0;
>>> +
>>> +       nla_parse(tb, DPLL_A_MAX, genlmsg_data(info->genlhdr),
>>> +                 genlmsg_len(info->genlhdr), NULL, info->extack);
>>> +       if (tb[DPLL_A_MODE]) {
>>Hi,
>>
>>Here should be something like:
>>               if (!ops->mode_set)
>>                       return -EOPNOTSUPP;
>
>Why? All drivers implement that.
>I believe that it's actullaly better that way. For a called setting up
>the same mode it is the dpll in, there should be 0 return by the driver.
>Note that driver holds this value. I'd like to keep this code as it is.

Actually, you are correct Petr, my mistake. Actually, no driver
implements this. Arkadiusz, could you please remove this op and
possibly any other unused  op? It will be added when needed.

Thanks!


>
>[...]