linux-kernel - Re: [irqchip: irq/irqchip-next] Revert "irqchip/mxs: Include linux/irqchip/mxs.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <246274e5-851d-4cea-8e01-d165ebd967f9@app.fastmail.com>
Date:   Wed, 21 Jun 2023 15:37:55 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     linux-kernel@...r.kernel.org
Cc:     "Marc Zyngier" <maz@...nel.org>, "Shawn Guo" <shawnguo@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>
Subject: Re: [irqchip: irq/irqchip-next] Revert "irqchip/mxs: Include
 linux/irqchip/mxs.h"

On Wed, Jun 21, 2023, at 14:57, irqchip-bot for Marc Zyngier wrote:
> The following commit has been merged into the irq/irqchip-next branch 
> of irqchip:
>
> Commit-ID:     d93c22199966696cfb76c6942797de2fbb22da24
> Gitweb:        
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d93c22199966696cfb76c6942797de2fbb22da24
> Author:        Marc Zyngier <maz@...nel.org>
> AuthorDate:    Wed, 21 Jun 2023 13:46:25 +01:00
> Committer:     Marc Zyngier <maz@...nel.org>
> CommitterDate: Wed, 21 Jun 2023 13:50:53 +01:00
>
> Revert "irqchip/mxs: Include linux/irqchip/mxs.h"
>
> This reverts commit 5b7e5676209120814dbb9fec8bc3769f0f7a7958.
>
> Although including linux/irqchip/mxs.h is technically correct,
> this clashes with the parallel removal of this include file
> with 32bit ARM modernizing the low level irq handling as part of
> 5bb578a0c1b8 ("ARM: 9298/1: Drop custom mdesc->handle_irq()").
>
> As such, this patch is not only unnecessary, it also breaks
> compilation in -next. Revert it.
>
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Shawn Guo <shawnguo@...nel.org>

Thanks! I had prepared the same patch but not yet sent it as I
was still debugging some unrelated issues. Once 5bb578a0c1b8
ends up in mainline, we can get back to fixing the warning
by marking the handler as 'static'.

     Arnd