linux-kernel - [PATCH][next] hpfs: remove redundant variable r

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230621140055.2679143-1-colin.i.king@gmail.com>
Date:   Wed, 21 Jun 2023 15:00:55 +0100
From:   Colin Ian King <colin.i.king@...il.com>
To:     Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] hpfs: remove redundant variable r

Variable r is being assigned a value that is not being read, the
assignment and the variable are redundant and can be removed. It
is also useful to remove r as it's a confusing shadow of another
variable r declared in a higher scope. Cleans up clang scan build
warning:

fs/hpfs/namei.c:560:8: warning: Although the value stored to 'r'
is used in the enclosing expression, the value is never actually
read from 'r' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 fs/hpfs/namei.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c
index 69fb40b2c99a..d892a6f74431 100644
--- a/fs/hpfs/namei.c
+++ b/fs/hpfs/namei.c
@@ -556,8 +556,7 @@ static int hpfs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
 	de.hidden = new_name[0] == '.';
 
 	if (new_inode) {
-		int r;
-		if ((r = hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1)) != 2) {
+		if (hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1) != 2) {
 			if ((nde = map_dirent(new_dir, hpfs_i(new_dir)->i_dno, new_name, new_len, NULL, &qbh1))) {
 				clear_nlink(new_inode);
 				copy_de(nde, &de);
-- 
2.39.2