linux-kernel - Re: [PATCH 5/7] thermal: int340x: processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a30d512c5994575466c4d67901ba6ab0fd2fd81.camel@intel.com>
Date:   Wed, 21 Jun 2023 14:12:14 +0000
From:   "Zhang, Rui" <rui.zhang@...el.com>
To:     "srinivas.pandruvada@...ux.intel.com" 
        <srinivas.pandruvada@...ux.intel.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>
CC:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/7] thermal: int340x: processor_thermal: Add workload
 type hint

On Tue, 2023-06-20 at 16:01 -0700, Srinivas Pandruvada wrote:
> 
> diff --git
> a/drivers/thermal/intel/int340x_thermal/processor_thermal_wlt_hint.c
> b/drivers/thermal/intel/int340x_thermal/processor_thermal_wlt_hint.c
> new file mode 100644
> index 000000000000..6b72ba665167
> --- /dev/null
> +++
> b/drivers/thermal/intel/int340x_thermal/processor_thermal_wlt_hint.c
> @@ -0,0 +1,239 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * processor thermal device for reading Workload type hints
> + * from the user space. The hints are provided by the firmware.
> + *
> + * Operation:
> + * When user space enables workload type prediction:
> + * - Use mailbox to configure:
> + *     Configure notification delay
> + *     Enable processor thermal device interrupt
> + * - The predicted workload type can be read from MMIO:
> + *     Offset 0x5B18 shows if there was an interrupt
> + *     active for change in workload type and also
> + *     predicted workload type.
> + *
> + * Two interface function

s/function/functions

>  are provided to call when there is a
> + * thermal device interrupt:
> + * - proc_thermal_check_wlt_intr(): Check if the is interrupt for
> + * change in workload type.

s/is interrupt/ interrupt is ?

> + * - proc_thermal_wlt_intr_callback(): Callback for interrupt
> + * under thread context to process. This involves sending
> + * notification to user space that there is a change in workload
> + * type.
> + *
> + * Copyright (c) 2020-2023, Intel Corporation.

This is new code, should the copyright starts from 2020?

thanks,
rui