[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230622093648.3795e325@kernel.org>
Date: Thu, 22 Jun 2023 09:36:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Igor Russkikh <irusskikh@...vell.com>,
Arnd Bergmann <arnd@...nel.org>
Cc: Simon Horman <simon.horman@...igine.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Tom Rix <trix@...hat.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <llvm@...ts.linux.dev>
Subject: Re: [EXT] Re: [PATCH] net: atlantic: fix ring buffer alignment
On Thu, 22 Jun 2023 07:49:52 +0200 Igor Russkikh wrote:
> > Agreed that the comment is confusing seems to be incorrect post-change.
> > Flags for instance are overlapped with len, is_gso etc. so they can't be
> > a separate 8B at the end.
> >
> > Igor, please advise how you want to proceed.
>
> I do agree better to remove the comment at all - it explains almost nothing.
>
> Thats not a hardware related structure, so explicit pack is for sure not required.
>
> Acked-by: Igor Russkikh <irusskikh@...vell.com>
Thanks Igor!
Arnd, could you respin with the comment removed?
Powered by blists - more mailing lists