linux-kernel - Re: [PATCH] perf test: Remove x permission from lib/stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fULkA2G7xWVH9okqEmYMFW_HhjFvtkoxid0YLngBZP4Dg@mail.gmail.com>
Date:   Thu, 22 Jun 2023 10:51:47 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org,
        Kan Liang <kan.liang@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf test: Remove x permission from lib/stat_output.sh

On Wed, Jun 21, 2023 at 10:58 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> The commit fc51fc87b1b8 factored out the helper functions to a library
> but the new file had execute permission.  Due to the way it detects
> the shell test scripts, it showed up in the perf test list unexpectedly.
>
>   $ ./perf test list 2>&1 | grep 86
>    76: x86 bp modify
>    77: x86 Sample parsing
>    78: x86 hybrid
>    86:                        <---- (here)
>
>   $ ./perf test -v 86
>    86:                                                                 :
>   --- start ---
>   test child forked, pid 1932207
>   test child finished with 0
>   ---- end ----
>   : Ok
>
> As it's a collection of library functions, it should not run as is.
> Let's remove the execute permission.
>
> Fixes: fc51fc87b1b8 ("perf test: Move all the check functions of stat CSV output to lib")
> Cc: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/lib/stat_output.sh | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 tools/perf/tests/shell/lib/stat_output.sh
>
> diff --git a/tools/perf/tests/shell/lib/stat_output.sh b/tools/perf/tests/shell/lib/stat_output.sh
> old mode 100755
> new mode 100644
> --
> 2.41.0.162.gfafddb0af9-goog
>