linux-kernel - [PATCH] usb: ohci-at91: Fix the unhandle interrupt when resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2023 10:57:39 +0800
From:   Guiting Shen <aarongt.shen@...il.com>
To:     stern@...land.harvard.edu, gregkh@...uxfoundation.org,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        claudiu.beznea@...rochip.com
Cc:     linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Guiting Shen <aarongt.shen@...il.com>
Subject: [PATCH] usb: ohci-at91: Fix the unhandle interrupt when resume

The ohci_hcd_at91_drv_suspend() sets ohci->rh_state to OHCI_RH_HALTED when
suspend which will let the ohci_irq() skip the interrupt after resume. And
nobody to handle this interrupt.

Set the ohci->rh_state to OHCI_RH_SUSPEND instead of OHCI_RH_HALTED when
suspend to fix it.

Signed-off-by: Guiting Shen <aarongt.shen@...il.com>
---
 drivers/usb/host/ohci-at91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index b9ce8d80f20b..7a970e573668 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -645,7 +645,7 @@ ohci_hcd_at91_drv_suspend(struct device *dev)
 	 * REVISIT: some boards will be able to turn VBUS off...
 	 */
 	if (!ohci_at91->wakeup) {
-		ohci->rh_state = OHCI_RH_HALTED;
+		ohci->rh_state = OHCI_RH_SUSPENDED;
 
 		/* flush the writes */
 		(void) ohci_readl (ohci, &ohci->regs->control);
-- 
2.25.1