lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 22 Jun 2023 11:49:13 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Wilken Gottwalt <wilken.gottwalt@...teo.net>
Cc:     linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: corsair-psu: add support for reading PWM values
 and mode

On 6/22/23 10:51, Wilken Gottwalt wrote:
> On Thu, 22 Jun 2023 10:42:31 -0700
> Guenter Roeck <linux@...ck-us.net> wrote:
> 
>> On Thu, Jun 22, 2023 at 05:09:28PM +0000, Wilken Gottwalt wrote:
>>> Also updates the documentation accordingly.
>>>
>>> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@...teo.net>
>>> ---
>>> Changes in v2:
>>>    - removed cleanup and typo fixes, sticking to feature adding only
>>> ---
>>
>> Applied to hwmon-next.
>>
>> Note: The patch description should describe what the patch does,
>> which isn't just "Also updates the documentation accordingly."
>> I'll fix that up, but please keep in mind for later.
> 
> Thank you. So what is the best practice if the title tells it all? I'm
> always a bit uncertain what to add to the body if there is nothing more.
> Just repeat it?
> 

Pretty much yes. Plus added prosa if you like.

Guenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ