[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230622-campsite-uncloak-37c292c37862@spud>
Date: Thu, 22 Jun 2023 20:18:54 +0100
From: Conor Dooley <conor@...nel.org>
To: kah.jing.lee@...el.com
Cc: Dinh Nguyen <dinguyen@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org,
Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@...el.com>
Subject: Re: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout
for UBIFS
On Thu, Jun 22, 2023 at 04:53:19PM +0800, kah.jing.lee@...el.com wrote:
> From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@...el.com>
>
> This patch is to update the QSPI flash layout to support UBIFS in mtd
> root partition.
That much is clear from the diff. Surely it'd be better to explain *why*
this change is being made, no?
Thanks,
Conor.
>
> Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@...el.com>
> Signed-off-by: Kah Jing Lee <kah.jing.lee@...el.com>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
> arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 38ae674f2f02..12b960b9183c 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -202,12 +202,12 @@ partitions {
>
> qspi_boot: partition@0 {
> label = "Boot and fpga data";
> - reg = <0x0 0x03FE0000>;
> + reg = <0x0 0x04200000>;
> };
>
> - qspi_rootfs: partition@...0000 {
> - label = "Root Filesystem - JFFS2";
> - reg = <0x03FE0000 0x0C020000>;
> + root: partition@...0000 {
> + label = "Root Filesystem - UBIFS";
> + reg = <0x04200000 0x0BE00000>;
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> index 07c3f8876613..608017e6e36a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> @@ -128,12 +128,12 @@ partitions {
>
> qspi_boot: partition@0 {
> label = "Boot and fpga data";
> - reg = <0x0 0x03FE0000>;
> + reg = <0x0 0x04200000>;
> };
>
> - qspi_rootfs: partition@...0000 {
> - label = "Root Filesystem - JFFS2";
> - reg = <0x03FE0000 0x0C020000>;
> + root: partition@...0000 {
> + label = "Root Filesystem - UBIFS";
> + reg = <0x04200000 0x0BE00000>;
> };
> };
> };
> --
> 2.25.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists