linux-kernel - Re: [PATCH net-next] dt-bindings: net: altr,tse: Fix error in "compatible" conditional schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230622-germless-unless-02d29924ddf2@spud>
Date:   Thu, 22 Jun 2023 20:54:57 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: altr,tse: Fix error in
 "compatible" conditional schema

Hey Rob,

On Wed, Jun 21, 2023 at 05:10:12PM -0600, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

You waiting for some of these to land before updating dt-schema?

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/net/altr,tse.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/altr,tse.yaml b/Documentation/devicetree/bindings/net/altr,tse.yaml
> index 9d02af468906..f5d3b70af07a 100644
> --- a/Documentation/devicetree/bindings/net/altr,tse.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,tse.yaml
> @@ -72,8 +72,8 @@ allOf:
>          compatible:
>            contains:
>              enum:
> -              - const: altr,tse-1.0
> -              - const: ALTR,tse-1.0
> +              - altr,tse-1.0
> +              - ALTR,tse-1.0
>      then:
>        properties:
>          reg:
> -- 
> 2.40.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)