linux-kernel - Re: [PATCH v3 2/3] selftests/user_events: Enable the event before write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2023 20:24:02 +0000
From:   Beau Belgrave <beaub@...ux.microsoft.com>
To:     sunliming <sunliming@...inos.cn>
Cc:     rostedt@...dmis.org, mhiramat@...nel.org, kelulanainsley@...il.com,
        linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] selftests/user_events: Enable the event before
 write_fault test in ftrace self-test

On Wed, Jun 21, 2023 at 02:34:38PM +0800, sunliming wrote:
> The user_event has not be enabled in write_fault test in ftrace
> self-test, Just enable it.
> 
> Signed-off-by: sunliming <sunliming@...inos.cn>

Good catch.

Acked-by: Beau Belgrave <beaub@...ux.microsoft.com>

Thanks!

> ---
>  tools/testing/selftests/user_events/ftrace_test.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
> index abfb49558a26..d33bd31425db 100644
> --- a/tools/testing/selftests/user_events/ftrace_test.c
> +++ b/tools/testing/selftests/user_events/ftrace_test.c
> @@ -373,6 +373,10 @@ TEST_F(user, write_fault) {
>  	ASSERT_EQ(0, ioctl(self->data_fd, DIAG_IOCSREG, &reg));
>  	ASSERT_EQ(0, reg.write_index);
>  
> +	/* Enable event */
> +	self->enable_fd = open(enable_file, O_RDWR);
> +	ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
> +
>  	/* Write should work normally */
>  	ASSERT_NE(-1, writev(self->data_fd, (const struct iovec *)io, 2));
>  
> -- 
> 2.25.1