linux-kernel - Re: [PATCH 2/3] dt-bindings: power: supply: Document Mitsumi MM8013 fuel gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e4840e0-adb6-010b-8186-0b3e38b4a374@linaro.org>
Date:   Thu, 22 Jun 2023 08:24:01 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: power: supply: Document Mitsumi MM8013
 fuel gauge

On 22/06/2023 02:51, Konrad Dybcio wrote:
> On 21.06.2023 18:38, Krzysztof Kozlowski wrote:
>> On 21/06/2023 17:39, Konrad Dybcio wrote:
>>> The Mitsumie MM8013 is an I2C fuel gauge for Li-Ion cells. The partial
>>
>> Mitsumi

...

>>
>>
>> I think you miss several properties: three power supplies (although not
>> all might be needed) and most likely monitored-battery. One regulator
>> output and output GPIO probably can be skipped.
> Looking at the example circuit, it seems like the chip's power lines are
> hardwired to the battery cell.
> 
> monitored-battery does not seem useful today, as we don't have any
> information about writing values onto the chip :/ And I'm not w

OK. With the typo in commit msg:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof