linux-kernel - Re: [LTP] [linux-next:master] [scsi] eca2040972: ltp.ioprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09815276-c515-7f3b-e81c-6c60e9ebfe4c@kernel.org>
Date:   Thu, 22 Jun 2023 17:30:22 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Petr Vorel <pvorel@...e.cz>, Niklas Cassel <Niklas.Cassel@....com>
Cc:     Cyril Hrubis <chrubis@...e.cz>,
        kernel test robot <oliver.sang@...el.com>,
        "lkp@...el.com" <lkp@...el.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Hannes Reinecke <hare@...e.de>,
        "oe-lkp@...ts.linux.dev" <oe-lkp@...ts.linux.dev>,
        Christoph Hellwig <hch@....de>,
        "ltp@...ts.linux.it" <ltp@...ts.linux.it>
Subject: Re: [LTP] [linux-next:master] [scsi] eca2040972:
 ltp.ioprio_set03.fail

On 6/22/23 16:32, Petr Vorel wrote:
>> On Wed, Jun 21, 2023 at 02:47:43PM +0200, Cyril Hrubis wrote:
>>> Hi!
>>>>> kernel test robot noticed "ltp.ioprio_set03.fail" on:
> 
>>>> LTP maintainers,
> 
>>>> Patches have been submitted to fix this issue. Were these patches applied ?
> 
>>> Looks like they are in, at least these two:
> 
>>>     ioprio: use ioprio.h kernel header if it exists
>>>     ioprio: Use IOPRIO_PRIO_NUM to check prio range
> 
>>> And there does not seem to be anything ioprio related haning in the LTP
>>> patchwork.
> 
> Hi Niklas,
> 
>> Hello Cyril, Petr, Damien,
> 
> 
>> I just ran LTP master + linux-next and the test case passes for me.
> 
> 
>> Although, note that even if you are using LTP master,
>> the way that the LTP header:
>> testcases/kernel/syscalls/ioprio/ioprio.h
>> is written, you will need to run
> 
>> make headers_install
>> with linux-next kernel source,
> 
>> before running
>> make autotools && ./configure
>> in LTP.
> 
>> Otherwise LTP will use the kernel uapi headers from your distro,
>> which does not perform the new checks for the IOPRIO_PRIO_VALUE()
>> macro. (It requires linux uapi headers from linux-next.)
> 
> Yes, it should do otherwise more tests would be often broken.
> 
> 
>> Does the linux kernel test robot not run
>> make headers_install
>> before running
>> make autotools && ./configure
>> in LTP?
> 
> I guess that's the question for Damien (I and Cyril have nothing to do with
> kernel test robot). I wonder myself.

Sorry, but I have nothing to do with the kernel robot either. I am only acting
when I get notified of a problem due to one of my patches.

-- 
Damien Le Moal
Western Digital Research