linux-kernel - Re: [PATCH 4/6] KVM: Documentation: Add the missing tdp_mmu_root_count into kvm_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1af0f4de320fd5ba96d63b7f0bdbbb061a7466f2.camel@intel.com>
Date:   Thu, 22 Jun 2023 08:37:28 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "mizhang@...gle.com" <mizhang@...gle.com>
CC:     "jmattson@...gle.com" <jmattson@...gle.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dmatlack@...gle.com" <dmatlack@...gle.com>,
        "bgardon@...gle.com" <bgardon@...gle.com>
Subject: Re: [PATCH 4/6] KVM: Documentation: Add the missing
 tdp_mmu_root_count into kvm_mmu_page

On Sun, 2023-06-18 at 00:08 +0000, Mingwei Zhang wrote:
> Add tdp_mmu_root_count into kvm_mmu_page description. tdp_mmu_root_count is
> an atomic counter used only in TDP MMU. Its usage and meaning is slightly
> different with root_counter in shadow MMU. Update the doc.
> 
> Signed-off-by: Mingwei Zhang <mizhang@...gle.com>
> ---
>  Documentation/virt/kvm/x86/mmu.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/virt/kvm/x86/mmu.rst b/Documentation/virt/kvm/x86/mmu.rst
> index 36bfe0fe02bb..3dce2426ad6d 100644
> --- a/Documentation/virt/kvm/x86/mmu.rst
> +++ b/Documentation/virt/kvm/x86/mmu.rst
> @@ -230,6 +230,12 @@ Shadow pages contain the following information:
>      A counter keeping track of how many hardware registers (guest cr3 or
>      pdptrs) are now pointing at the page.  While this counter is nonzero, the
>      page cannot be destroyed.  See role.invalid.
> +  tdp_mmu_root_count:
> +    An atomic reference counter in TDP MMU that allows for parallel
					     ^
Please explicitly say "TDP MMU root page" ?
			
> +    accesses.  Accessing the page requires lifting the counter value. The
> +    initial value is set as 2 indicating one reference from vCPU and one
			    ^
			    to ?

> +    from TDP MMU itself. 
> 


> While this counter is nonzero, the page cannot be
> +    destroyed. 
> 

I guess this sentence is implied by "reference counter" mentioned in the first
sentence.

> Note this field is a union with root_count.
>