linux-kernel - Re: [PATCH net-next v1 03/14] net: phy: nxp-c45-tja11xx: remove RX BIST frame counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39388ce8-44d8-8869-965c-a66f855fb4ab@oss.nxp.com>
Date:   Thu, 22 Jun 2023 15:21:32 +0300
From:   "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        richardcochran@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sebastian.tobuschat@....com
Subject: Re: [PATCH net-next v1 03/14] net: phy: nxp-c45-tja11xx: remove RX
 BIST frame counters

On 16.06.2023 23:39, Andrew Lunn wrote:
> On Fri, Jun 16, 2023 at 04:53:12PM +0300, Radu Pirea (NXP OSS) wrote:
>> RX BIST frame counters can be used only when the PHY is in test mode. In
>> production mode, the counters will be always read as 0. So, they don't
>> provide any useful information and are removed from the statistics.
> 
> Hummm
> 
> I wounder if this would be considered an ABI change?
> 
>          Andrew

It can be considered an ABI change, but will not break the userspace 
compilation. A functional change will be introduced anyway because these 
counters will not be reported, but they don't provide useful 
information. These counters will always be 0. In the worst-case 
scenario, we can add them back.

-- 
Radu P.