[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <19e93057-46e4-1578-9e3e-138bd09cccfc@gmail.com>
Date: Thu, 22 Jun 2023 09:42:27 +0800
From: Jacky Huang <ychuang570808@...il.com>
To: Arnd Bergmann <arnd@...db.de>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-clk@...r.kernel.org, soc@...nel.org,
krzysztof.kozlowski+dt@...aro.org, schung@...oton.com,
Jacky Huang <ychuang3@...oton.com>
Subject: Re: [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern
functions
On 2023/6/21 下午 10:22, Arnd Bergmann wrote:
> On Wed, Jun 21, 2023, at 05:16, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@...oton.com>
>>
>> Moved the declaration of extern functions ma35d1_reg_clk_pll() and
>> ma35d1_reg_adc_clkdiv() from the .c files to the newly created header
>> file clk-ma35d1.h.
>>
>> Signed-off-by: Jacky Huang <ychuang3@...oton.com>
>
>> #define PLL_MAX_NUM 5
>> @@ -20,19 +22,19 @@ static DEFINE_SPINLOCK(ma35d1_lock);
>> #define REG_CLK_PWRCTL 0x00
>> #define REG_CLK_SYSCLK0 0x04
>> #define REG_CLK_SYSCLK1 0x08
>> -#define REG_CLK_APBCLK0 0x0C
>> +#define REG_CLK_APBCLK0 0x0c
>> #define REG_CLK_APBCLK1 0x10
>> #define REG_CLK_APBCLK2 0x14
>> #define REG_CLK_CLKSEL0 0x18
>> -#define REG_CLK_CLKSEL1 0x1C
>> +#define REG_CLK_CLKSEL1 0x1c
>> #define REG_CLK_CLKSEL2 0x20
>> #define REG_CLK_CLKSEL3 0x24
>> #define REG_CLK_CLKSEL4 0x28
>> -#define REG_CLK_CLKDIV0 0x2C
>> +#define REG_CLK_CLKDIV0 0x2c
>> #define REG_CLK_CLKDIV1 0x30
>> #define REG_CLK_CLKDIV2 0x34
>> #define REG_CLK_CLKDIV3 0x38
>> -#define REG_CLK_CLKDIV4 0x3C
>> +#define REG_CLK_CLKDIV4 0x3c
>> #define REG_CLK_CLKOCTL 0x40
>> #define REG_CLK_STATUS 0x50
>> #define REG_CLK_PLL0CTL0 0x60
> This part of the patch does not relate to the decription, it
> looks like a minor cleanup that should be a separate patch.
>
> The actual change looks good and required, but I can't apply it
> if it's mixed with unrelated changes like this.
>
> Arnd
Dear Arnd,
Thanks for the advice.
I will extract the unrelated parts from this patch and create another
patch for them.
Best Regards,
Jacky Huang
Powered by blists - more mailing lists