linux-kernel - Re: [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e7011fe-6757-e89f-c3c5-d5f87cf83766@redhat.com>
Date:   Thu, 22 Jun 2023 14:35:51 +0200
From:   Jocelyn Falempe <jfalempe@...hat.com>
To:     Sui Jingfeng <suijingfeng@...ngson.cn>,
        Dave Airlie <airlied@...hat.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, Tom Rix <trix@...hat.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE

This patch was already sent by Tom Rix last month:
https://patchwork.freedesktop.org/series/117881/

I can push it to drm-misc-next, if Thomas is ok.

Best regards,

-- 

Jocelyn

On 21/06/2023 21:11, Sui Jingfeng wrote:
> drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static?
> 
> Found in the log of Fi.CI.SPARSE test [1]
> 
> [1] https://patchwork.freedesktop.org/series/119249/
> 
> Signed-off-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> ---
>   drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 976f0ab2006b..abddf37f0ea1 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -20,7 +20,7 @@
>   
>   #include "mgag200_drv.h"
>   
> -int mgag200_modeset = -1;
> +static int mgag200_modeset = -1;
>   MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>   module_param_named(modeset, mgag200_modeset, int, 0400);
>