[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VdJjeMwHt31tKeiVLbS36aGmhDgGowT951UVwkxr2_VXQ@mail.gmail.com>
Date: Thu, 22 Jun 2023 17:15:43 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: nick.hawkins@....com
Cc: verdun@....com, linus.walleij@...aro.org, brgl@...ev.pl,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
jdelvare@...e.com, linux@...ck-us.net, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v4 1/5] gpio: gxp: Add HPE GXP GPIO
On Thu, Jun 22, 2023 at 12:35 AM <nick.hawkins@....com> wrote:
>
> From: Nick Hawkins <nick.hawkins@....com>
>
> The GXP SoC supports GPIO on multiple interfaces. The interfaces are
> CPLD and Host. The GPIOs is a combination of both physical and virtual
GPIOs are
> I/O across the interfaces. The gpio-gxp driver specifically covers the
> CSM(physical), FN2(virtual), and VUHC(virtual) which are the host. The
"...are the host"?! hosts?
> driver supports interrupts from the host.
I will have some comments against the code, but I will try to review
it probably later on (next week or so). Taking into account the
approaching release date, I think we have a couple more months for
polishing this series.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists