[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230622144627.GA1672260-robh@kernel.org>
Date: Thu, 22 Jun 2023 08:46:27 -0600
From: Rob Herring <robh@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
vkoul@...nel.org, kishon@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
gregkh@...uxfoundation.org, catalin.marinas@....com,
will@...nel.org, p.zabel@...gutronix.de, arnd@...db.de,
geert+renesas@...der.be, neil.armstrong@...aro.org,
nfraprado@...labora.com, broonie@...nel.org, rafal@...ecki.pl,
quic_srichara@...cinc.com, quic_varada@...cinc.org,
quic_wcheng@...cinc.com, linux-arm-msm@...r.kernel.org,
linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB
phy
On Thu, Jun 22, 2023 at 11:52:09AM +0530, Varadarajan Narayanan wrote:
> Document the M31 USB2 phy present in IPQ5332.
>
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
> v1:
> Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml
> Drop default binding "m31,usb-hsphy"
> Add clock
> Remove 'oneOf' from compatible
> Remove 'qscratch' region from register space as it is not needed
> Remove reset-names
> Fix the example definition
> ---
> .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 51 ++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml b/Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
> new file mode 100644
> index 0000000..ab2e945
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: M31 (https://www.m31tech.com) USB PHY
Put the URL in 'description'.
> +
> +maintainers:
> + - Sricharan Ramabadhran <quic_srichara@...cinc.com>
> + - Varadarajan Narayanan <quic_varada@...cinc.org>
.org? It's .com everywhere else.
> +
> +description:
> + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs.
Where's the IPQ5018 compatible?
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - qcom,ipq5332-usb-hsphy
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + maxItems: 1
> + contains:
'contains' is not appropriate here. Drop.
> + items:
> + - const: cfg_ahb
Don't need both items list and maxItems. Really, you don't need
'clock-names' at all because there is only 1 clock.
> +
> + resets:
> + maxItems: 1
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
> + usbphy0: ipq5332-hsphy@...00 {
Drop unused labels.
> + compatible = "qcom,ipq5332-usb-hsphy";
> + reg = <0x0007b000 0x12c>;
> +
> + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>;
> + clock-names = "cfg_ahb";
> +
> + resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
Whitespace errors in here.
> + };
> +
> --
> 2.7.4
>
Powered by blists - more mailing lists