[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZJRhD8QoqMtg8reI@smile.fi.intel.com>
Date: Thu, 22 Jun 2023 17:56:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Lee Jones <lee@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: ipaq-micro: Use %*ph for printing hexdump of
a small buffer
On Thu, Jun 22, 2023 at 03:00:58PM +0100, Lee Jones wrote:
> On Thu, 22 Jun 2023, Andy Shevchenko wrote:
> > On Wed, Jun 21, 2023 at 06:10:40PM +0100, Lee Jones wrote:
> > > On Tue, 13 Jun 2023, Andy Shevchenko wrote:
> > > > The kernel already has a helper to print a hexdump of a small
> > > > buffer via pointer extension. Use that instead of open coded
> > > > variant.
> > >
> > > That's not all you're doing is it?
> > >
> > > Nice try. 2 patches please.
> >
> > I'm not sure it's possible to split to two clean patches that don't overlap
> > each other like by 70%. Can you elaborate a bit more on your vision on this?
>
> What does the 'break' have to do with changing print format?
Ah, indeed! Thank you for spotting this. Yes, 2 patches.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists