linux-kernel - Re: [PATCH] syscalls: Remove file path comments from headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <388c9fbb-2782-4990-b432-eeb999308869@app.fastmail.com>
Date:   Thu, 22 Jun 2023 17:10:34 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Sohil Mehta" <sohil.mehta@...el.com>
Cc:     linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH] syscalls: Remove file path comments from headers

On Thu, Jun 22, 2023, at 00:36, Sohil Mehta wrote:
> Source file locations for syscall definitions can change over a period
> of time. File paths in comments get stale and are hard to maintain long
> term. Also, their usefulness is questionable since it would be easier to
> locate a syscall definition using the SYSCALL_DEFINEx() macro.
>
> Remove all source file path comments from the syscall headers. Also,
> equalize the uneven line spacing (some of which is introduced due to the
> deletions).
>
> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
> ---
>  include/linux/compat.h                  |  82 ++------------
>  include/linux/syscalls.h                | 140 +++---------------------
>  include/uapi/asm-generic/unistd.h       | 129 +++++-----------------
>  kernel/sys_ni.c                         | 110 +------------------
>  tools/include/uapi/asm-generic/unistd.h | 129 +++++-----------------
>  5 files changed, 85 insertions(+), 505 deletions(-)

Applied to the asm-generic tree, thanks!

   Arnd