linux-kernel - Re: [PATCH 3/8] arm64: dts: qcom: msm8939-samsung-a7: Add touch key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2023 17:11:48 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Lin, Meng-Bo" <linmengbo0689@...tonmail.com>,
        linux-kernel@...r.kernel.org
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Nikita Travkin <nikita@...n.ru>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 3/8] arm64: dts: qcom: msm8939-samsung-a7: Add touch key

On 22/06/2023 04:04, Lin, Meng-Bo wrote:
> Add the CORERIVER TC360 touch key together with the necessary
> fixed regulator for it.
> 
> Note that for some reason Samsung decided to connect this to GPIOs
> where no hardware I2C bus is available, so we need to fall back
> to software bit-banging using i2c-gpio.

Squash patches doing one logical change. That change is: adding new
board. Since you sent it as one patchset, then one commit is to add new
DTS. There is no point in sending piece of board and immediately another
piece. It's not release early, release often.

Best regards,
Krzysztof