linux-kernel - Re: [PATCH v2 03/13] net: phy: nxp-c45-tja11xx: add *_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJXzRzJy99d3v7FY@corigine.com>
Date:   Fri, 23 Jun 2023 21:32:23 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@....nxp.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, richardcochran@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        sebastian.tobuschat@....com
Subject: Re: [PATCH v2 03/13] net: phy: nxp-c45-tja11xx: add *_reg_field
 functions

On Fri, Jun 23, 2023 at 10:41:13AM +0300, Radu Pirea (NXP OSS) wrote:
> Between TJA1120 and TJA1103 the hardware was improved, but some register
> addresses were changed and some bit fields were moved from one register
> to another.
> 
> To integrate more PHYs in the same driver with the same register fields,
> but these register fields located in different registers at
> different offsets, I introduced the nxp_c45_reg_field structure.
> 
> Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>
> ---
>  drivers/net/phy/nxp-c45-tja11xx.c | 82 +++++++++++++++++++++++++++++++
>  1 file changed, 82 insertions(+)
> 
> diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
> index f1f15a1b6cfc..2664b3bfcb35 100644
> --- a/drivers/net/phy/nxp-c45-tja11xx.c
> +++ b/drivers/net/phy/nxp-c45-tja11xx.c
> @@ -191,6 +191,21 @@ struct nxp_c45_skb_cb {
>  	unsigned int type;
>  };
>  
> +#define NXP_C45_REG_FIELD(_reg, _devad, _offset, _size)	\
> +	((struct nxp_c45_reg_field) {			\
> +		.reg = _reg,				\
> +		.devad =  _devad,			\
> +		.offset = _offset,			\
> +		.size = _size,				\
> +	})
> +
> +struct nxp_c45_reg_field {
> +	u16 reg;
> +	u8 devad;
> +	u8 offset;
> +	u8 size;
> +};
> +
>  struct nxp_c45_hwts {
>  	u32	nsec;
>  	u32	sec;
> @@ -225,6 +240,73 @@ struct nxp_c45_phy_stats {
>  	u16		mask;
>  };
>  
> +static int nxp_c45_read_reg_field(struct phy_device *phydev,
> +				  const struct nxp_c45_reg_field *reg_field)

Hi Radu,

I think this is resolved in a latter patch in this series.
But nxp_c45_read_reg_field is defined but not used.
As is nxp_c45_set_reg_field and nxp_c45_clear_reg_field.

This causes an allmodconfig build to fail on x86_64 with GCC 12.3.0.

-- 
pw-bot: changes-requested