linux-kernel - Re: [PATCH 1/2] mm: memcg: rename and document global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOUHufbb6aspJANQf7m2FYr6K6f-z04ii3SP5ZnQ0rLHL1ia2Q@mail.gmail.com>
Date:   Fri, 23 Jun 2023 14:39:07 -0600
From:   Yu Zhao <yuzhao@...gle.com>
To:     Yosry Ahmed <yosryahmed@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm: memcg: rename and document global_reclaim()

On Tue, Jun 20, 2023 at 8:30 PM Yosry Ahmed <yosryahmed@...gle.com> wrote:
>
> Evidently, global_reclaim() can be a confusing name. Especially that it
> used to exist before with a subtly different definition (removed by
> commit b5ead35e7e1d ("mm: vmscan: naming fixes: global_reclaim() and
> sane_reclaim()"). It can be interpreted as non-cgroup reclaim, even
> though it returns true for cgroup reclaim on the root memcg
> (through memory.reclaim).
>
> Rename it to root_reclaim() in an attempt to make it less ambiguous, and
> add documentation to it as well as cgroup_reclaim.
>
> Reported-by: Johannes Weiner <hannes@...xchg.org>
> Closes: https://lore.kernel.org/lkml/20230405200150.GA35884@cmpxchg.org/
> Signed-off-by: Yosry Ahmed <yosryahmed@...gle.com>

Acked-by: Yu Zhao <yuzhao@...gle.com>