linux-kernel - Re: [PATCH net-next v2 10/10] net: mdio: support C45-over-C22 when probed via OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJYFDcbZqI+EC3OX@corigine.com>
Date:   Fri, 23 Jun 2023 22:48:13 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Michael Walle <mwalle@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Marek Behún <kabel@...nel.org>,
        Xu Liang <lxu@...linear.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 10/10] net: mdio: support C45-over-C22 when
 probed via OF

On Fri, Jun 23, 2023 at 12:29:19PM +0200, Michael Walle wrote:

...

> @@ -178,24 +209,26 @@ int __of_mdiobus_register(struct mii_bus *mdio, struct device_node *np,
>  	if (rc)
>  		return rc;
>  
> -	/* Loop over the child nodes and register a phy_device for each phy */
> +	/* Loop over the child nodes, skipping C45 PHYs so we can scan for
> +	 * broken C22 PHYs. The C45 PHYs will be registered afterwards.
> +	 */
>  	for_each_available_child_of_node(np, child) {
> -		addr = of_mdio_parse_addr(&mdio->dev, child);
> -		if (addr < 0) {
> -			scanphys = true;
> +		if (of_mdiobus_child_is_c45_phy(child))
>  			continue;
> -		}
> +		rc = of_mdiobus_register_child(mdio, child, &scanphys);
> +		if (rc)
> +			goto unregister;
> +	}
>  
> -		if (of_mdiobus_child_is_phy(child))
> -			rc = of_mdiobus_register_phy(mdio, child, addr);
> -		else
> -			rc = of_mdiobus_register_device(mdio, child, addr);
> +	/* Some C22 PHYs are broken with C45 transactions. */
> +	mdiobus_scan_for_broken_c45_access(mdio);

Hi Michael,

Unfortunately this seems to cause a build fauilure
for x86_64 allmodconfig.

ERROR: modpost: "mdiobus_scan_for_broken_c45_access" [drivers/net/mdio/of_mdio.ko] undefined!

-- 
pw-bot: changes-requested