linux-kernel - Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2023 15:17:46 -0600
From:   Rob Herring <robh@...nel.org>
To:     Luca Weiss <luca.weiss@...rphone.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Abel Vesa <abel.vesa@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bart Van Assche <bvanassche@....org>,
        linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
        devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845
 by adding reg-names

On Fri, Jun 23, 2023 at 02:38:04PM +0200, Luca Weiss wrote:
> On Fri Jun 23, 2023 at 2:31 PM CEST, Krzysztof Kozlowski wrote:
> > On 23/06/2023 13:30, Abel Vesa wrote:
> > > There is a warning on dtbs check for sdm845, amongst other platforms,
> > > about the reg-names being unevaluated. Fix that by adding reg-names to
> > > the clocks and reg properties check for such platforms.
> > > 
> > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > > Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> > > ---
> > >  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > index 0209713d1f88..894b57117314 100644
> > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > > @@ -166,6 +166,10 @@ allOf:
> > >          reg:
> > >            minItems: 2
> > >            maxItems: 2
> > > +        reg-names:
> > > +          items:
> > > +            - const: std
> > > +            - const: ice
> >
> > reg-names looks like a new property, so it should be defined in
> > top-level and just constrained per-variant.
> >
> > Also there was similar approach:
> > https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com/
> >
> > but I guess no resends and it can be superseded.
> 
> Right, the patches got reviews but was never applied... I really need to
> find a strategy to keep track of sent patches until they're applied with
> my work mailbox, it's not the first time that a patch has gotten
> forgotten.

There was an error reported on the above series. Why would it be 
applied?

That said, I'm not sure SCSI maintainers consistently apply DT only 
patch series.

> With my private mailbox I just have a different folder for patches that
> have been sent which I archive once they're applied, but with work GMail
> I don't see how I can easily replicate this since it's also not grouping
> threads properly.

Yeah, GMail sucks for that. I use 'lei' to get all my patches and 
replies to them (though its caching will miss replies). Then I delete 
them from the mbox when they are applied or otherwise finished. lei 
updates won't re-add them to the mbox.

Rob