linux-kernel - Re: [PATCH v4] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20b480d8-087c-d5fe-08ca-7d2b684f4f96@linaro.org>
Date:   Fri, 23 Jun 2023 10:04:30 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Artur Weber <aweber.kernel@...il.com>,
        Olof Johansson <olof@...om.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>, soc@...nel.org,
        Rob Herring <robh+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v4] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards

On 22/06/2023 14:52, Artur Weber wrote:
> On 04/06/2023 21:15, Krzysztof Kozlowski wrote:
>> On 04/06/2023 18:56, Artur Weber wrote:
>>> +/*
>>> + * This device does not use the built-in RTC; instead, the RTC in the
>>> + * S5M8786 PMIC is used instead. Remove the unused node to avoid DTB check
>>> + * warnings.
>>> + */
>>> +/delete-node/ &rtc;
>>
>> This is not the solution. The S3C RTC is there. Just like all other
>> boards we have two RTCs and DTS should be complete. Definitely you
>> should not remove something just because there were warnings. Instead
>> warnings should be fixed.
> 
> The problem is that the built-in RTC does not seem to work on this
> device. I attempted to add it, using the same clocks as other devices
> in mainline using the S5M8676 PMIC:
> 
> &rtc {
> 	status = "okay";
> 	clocks = <&clock CLK_RTC>, <&s5m8767_osc S2MPS11_CLK_AP>;
> 	clock-names = "rtc", "rtc_src";
> };
> 
> However, it just prints the following on startup:
> 
>  s3c-rtc 10070000.rtc: rtc disabled, re-enabling
>  s3c-rtc 10070000.rtc: registered as rtc0
>  s3c-rtc 10070000.rtc: hctosys: unable to read the hardware clock

This should be debugged then... but with explanation is fine to leave
the node disabled.

Removal of nodes is almost never correct.


Best regards,
Krzysztof