linux-kernel - Re: [PATCH v4 3/4] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023062357-deceased-rejoicing-03d6@gregkh>
Date:   Fri, 23 Jun 2023 10:09:09 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Avadhut Naik <avadhut.naik@....com>
Cc:     rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, yazen.ghannam@....com,
        alexey.kardashevskiy@....com, linux-kernel@...r.kernel.org,
        avadnaik@....com
Subject: Re: [PATCH v4 3/4] platform/chrome: cros_ec_debugfs: Fix permissions
 for panicinfo

On Wed, Jun 21, 2023 at 03:51:01AM +0000, Avadhut Naik wrote:
> From: Avadhut Naik <Avadhut.Naik@....com>
> 
> The debugfs_create_blob() function has been used to create read-only binary
> blobs in debugfs. The function filters out permissions, other than S_IRUSR,
> S_IRGRP and S_IROTH, provided while creating the blobs.
> 
> The very behavior though is being changed through previous patch in the
> series (fs: debugfs: Add write functionality to debugfs blobs) which makes
> the binary blobs writable.
> 
> As such, rectify the permissions of panicinfo file to ensure it remains
> read-only.
> 
> Signed-off-by: Avadhut Naik <Avadhut.Naik@....com>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>