linux-kernel - Re: [PATCH v4] i2c: ocores: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJVWQIZRb49mhofo@shikoro>
Date:   Fri, 23 Jun 2023 10:22:24 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Wang Zhang <silver_code@...t.edu.cn>
Cc:     Peter Korsgaard <peter@...sgaard.com>,
        Andrew Lunn <andrew@...n.ch>,
        Andreas Larsson <andreas@...sler.com>,
        hust-os-kernel-patches@...glegroups.com,
        Peter Korsgaard <jacmet@...site.dk>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] i2c: ocores: use devm_ managed clks

On Fri, May 26, 2023 at 03:05:33PM +0800, Wang Zhang wrote:
> Smatch complains that:
> drivers/i2c/busses/i2c-ocores.c:704 ocores_i2c_probe()
> warn: missing unwind goto?
> 
> If any wrong occurs in ocores_i2c_of_probe, the i2c->clk needs to be
> released. But the function returns directly without freeing the clock.
> 
> Fix this by updating the code to use devm_clk_get_optional_enabled()
> instead. Use dev_err_probe() where appropriate as well since we are
> changing those statements.
> 
> Fixes: f5f35a92e44a ("i2c: ocores: Add irq support for sparc")
> Signed-off-by: Wang Zhang <silver_code@...t.edu.cn>

Applied to for-next with Andrew's Rev-by from v3 added, thanks!

Please send new versions of a patch as a new mail thread. This makes
handling easier for maintainers.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)