linux-kernel - Re: linux-next: build failure after merge of the bluetooth tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2023 10:34:03 +0200
From:   Alexander Mikhalitsyn <alexander@...alicyn.com>
To:     "Von Dentz, Luiz" <luiz.von.dentz@...el.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Christian Brauner <brauner@...nel.org>
Subject: Re: linux-next: build failure after merge of the bluetooth tree

On Fri, Jun 23, 2023 at 12:28 AM Von Dentz, Luiz
<luiz.von.dentz@...el.com> wrote:
>
> Hi Stephen, Alexander,

Dear friends,

>
> Looks like we have a similar problem as to:
>
> https://lore.kernel.org/lkml/20230524081933.44dc8bea@kernel.org/
>
> That said for unix socket it was decided to not allow it to be build as module, which is something I don't think we are willing to do for bluetooth, so we have to find a way to get around pidfd_prepare, which seems to be called due to the use of scm_recv (it is also used by netlink btw).

Ugh, yep. That's bad and we can't workaround it like we did for unix sockets.

Originally, Christian had objections against exporting the
pidfd_prepare function [1]

[1] https://lore.kernel.org/all/20230523-flechten-ortsschild-e5724ecc4ed0@brauner/

+cc Christian

Kind regards,
Alex

>
>
> ________________________________ From: Stephen Rothwell
> Sent: Monday, June 12, 2023 8:02 PM
> To: Marcel Holtmann; Johan Hedberg
> Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List
> Subject: linux-next: build failure after merge of the bluetooth tree
>
> Hi all,
>
> After merging the bluetooth tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
>
> Caused by commit
>
>   817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
>
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell