linux-kernel - Re: [PATCH] syscalls: Remove file path comments from headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230623-kalkulation-bangen-c6d30d1423a5@brauner>
Date:   Fri, 23 Jun 2023 14:25:50 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Sohil Mehta <sohil.mehta@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        linux-api@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH] syscalls: Remove file path comments from headers

On Wed, Jun 21, 2023 at 10:36:00PM +0000, Sohil Mehta wrote:
> Source file locations for syscall definitions can change over a period
> of time. File paths in comments get stale and are hard to maintain long
> term. Also, their usefulness is questionable since it would be easier to
> locate a syscall definition using the SYSCALL_DEFINEx() macro.
> 
> Remove all source file path comments from the syscall headers. Also,
> equalize the uneven line spacing (some of which is introduced due to the
> deletions).
> 
> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@...nel.org>