linux-kernel - Re: [PATCH 3/3] sfc: selftest: fix struct packing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f12f612-7fad-59c6-c7dd-dea49721842b@gmail.com>
Date:   Fri, 23 Jun 2023 13:57:39 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     David Laight <David.Laight@...LAB.COM>,
        Arnd Bergmann <arnd@...nel.org>,
        Martin Habets <habetsm.xilinx@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-net-drivers@....com" <linux-net-drivers@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] sfc: selftest: fix struct packing

On 23/06/2023 11:52, David Laight wrote:
> Maybe you can get away with adding a 16bit pad before the ethernet
> header so that the IP header is actually aligned.

That's what I ended up doing, because my original idea was
 overcomplicated and turned out super ugly.
See https://lore.kernel.org/netdev/6f87fdf5-1844-4633-b4fe-6b247bc6ab49@app.fastmail.com/T/

> (Then fight all the stuff that stops you doing a memcpy()
> that runs into a second field of a structure.)

Yeah, I don't know how you're meant to annotate that stuff.
I guess I'll have to wait until Kees shouts at me and tells
 me what to do :S

-ed