linux-kernel - Re: net: macb: sparse warning fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66f00ffc-571b-86b3-5c35-b9ce566cc149@microchip.com>
Date:   Fri, 23 Jun 2023 15:16:23 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>, <netdev@...r.kernel.org>,
        <pabeni@...hat.com>, <kuba@...nel.org>, <edumazet@...gle.com>,
        <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <claudiu.beznea@...rochip.com>
Subject: Re: net: macb: sparse warning fixes

Hi Ben,

On 22/06/2023 at 15:05, Ben Dooks wrote:
> These are 3 hopefully easy patches for fixing sparse errors due to
> endian-ness warnings. There are still some left, but there are not
> as easy as they mix host and network fields together.
> 
> For example, gem_prog_cmp_regs() has two u32 variables that it does
> bitfield manipulation on for the tcp ports and these are __be16 into
> u32, so not sure how these are meant to be changed. I've also no hardware
> to test on, so even if these did get changed then I can't check if it is
> working pre/post change.

Do you know if there could be any impact on performance (even if limited)?

Best regards,
   Nicolas

> Also gem_writel and gem_writel_n, it is not clear if both of these are
> meant to be host order or not.
> 
> Ben Dooks (3):
>    net: macb: check constant to define and fix __be32 warnings
>    net: macb: add port constant to fix __be16 warnings
>    net: macb: fix __be32 warnings in debug code
> 
>   drivers/net/ethernet/cadence/macb_main.c | 25 +++++++++++++-----------
>   1 file changed, 14 insertions(+), 11 deletions(-)

-- 
Nicolas Ferre