linux-kernel - Re: [PATCH] FS: JFS: Check for read-only mounted filesystem in txBegin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78557979-4de5-7012-d513-c4524477181f@oracle.com>
Date:   Fri, 23 Jun 2023 08:53:15 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     mirimmad@...look.com, shaggy@...nel.org
Cc:     Immad Mir <mirimmad17@...il.com>,
        jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FS: JFS: Check for read-only mounted filesystem in
 txBegin

On 6/23/23 8:47AM, mirimmad@...look.com wrote:
> From: Immad Mir <mirimmad17@...il.com>
> 
>   This patch adds a check for read-only mounted filesystem
>   in txBegin before starting a transaction potentially saving
>   from NULL pointer deref.

Thanks. I like this. Not much else we can do since none of the callers 
anticipate an error. I'll push it to jfs-next.

Shaggy

> 
> Signed-off-by: Immad Mir <mirimmad17@...il.com>
> ---
>   fs/jfs/jfs_txnmgr.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index ffd4feece..87dc4e3a4 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -353,7 +353,10 @@ tid_t txBegin(struct super_block *sb, int flag)
>   
>   	jfs_info("txBegin: flag = 0x%x", flag);
>   	log = JFS_SBI(sb)->log;
> -
> +	if (!log) {
> +		jfs_error(sb, "read-only filesystem\n");
> +		return 0;
> +	}
>   	TXN_LOCK();
>   
>   	INCREMENT(TxStat.txBegin);