[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <768b0591-ba30-ba0e-0992-2f312ac76f16@kernel.org>
Date: Fri, 23 Jun 2023 09:41:51 +0800
From: Chao Yu <chao@...nel.org>
To: Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: compress tmp files given extension
On 2023/6/22 15:12, Jaegeuk Kim wrote:
> Let's compress tmp files for the given extension list.
>
> This patch does not change the previous behavior, but allow the cases as below.
>
> Extention example: "ext"
>
> - abc.ext : allow
> - abc.ext.abc : allow
> - abc.extm : not allow
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
> Change log from v2:
> - fix parameters
>
> Change log from v1:
> - refactor to allow abc.ext.dontcare only
>
> fs/f2fs/namei.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 3e35eb7dbb8f..80806ce1289f 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -23,7 +23,7 @@
> #include <trace/events/f2fs.h>
>
> static inline bool is_extension_exist(const unsigned char *s, const char *sub,
> - bool tmp_ext)
> + bool tmp_ext, bool tmp_dot)
> {
> size_t slen = strlen(s);
> size_t sublen = strlen(sub);
> @@ -49,8 +49,12 @@ static inline bool is_extension_exist(const unsigned char *s, const char *sub,
> for (i = 1; i < slen - sublen; i++) {
> if (s[i] != '.')
> continue;
> - if (!strncasecmp(s + i + 1, sub, sublen))
> - return true;
> + if (!strncasecmp(s + i + 1, sub, sublen)) {
> + if (!tmp_dot)
> + return true;
> + if (i == slen - sublen - 1 || s[i + 1 + sublen] == '.')
> + return true;
> + }
> }
>
> return false;
> @@ -148,7 +152,7 @@ static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir,
> cold_count = le32_to_cpu(sbi->raw_super->extension_count);
> hot_count = sbi->raw_super->hot_ext_count;
> for (i = cold_count; i < cold_count + hot_count; i++)
> - if (is_extension_exist(name, extlist[i], false))
> + if (is_extension_exist(name, extlist[i], true, false))
> break;
> f2fs_up_read(&sbi->sb_lock);
> if (i < (cold_count + hot_count))
> @@ -156,12 +160,12 @@ static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir,
>
> /* Don't compress unallowed extension. */
> for (i = 0; i < noext_cnt; i++)
> - if (is_extension_exist(name, noext[i], false))
> + if (is_extension_exist(name, noext[i], true, false))
is_extension_exist(name, ext[i], true, true) ?
Thanks,
> return;
>
> /* Compress wanting extension. */
> for (i = 0; i < ext_cnt; i++) {
> - if (is_extension_exist(name, ext[i], false)) {
> + if (is_extension_exist(name, ext[i], true, true)) {
> set_compress_context(inode);
> return;
> }
> @@ -189,7 +193,7 @@ static void set_file_temperature(struct f2fs_sb_info *sbi, struct inode *inode,
> cold_count = le32_to_cpu(sbi->raw_super->extension_count);
> hot_count = sbi->raw_super->hot_ext_count;
> for (i = 0; i < cold_count + hot_count; i++)
> - if (is_extension_exist(name, extlist[i], true))
> + if (is_extension_exist(name, extlist[i], true, false))
> break;
> f2fs_up_read(&sbi->sb_lock);
>
Powered by blists - more mailing lists