| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230623144312.GE2112@pendragon.ideasonboard.com>
Date: Fri, 23 Jun 2023 17:43:12 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Thomas Zimmermann <tzimmermann@...e.de>,
Magnus Damm <magnus.damm@...il.com>,
dri-devel@...ts.freedesktop.org, linux-renesas-soc@...r.kernel.org,
linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH 01/39] dt-bindings: display: Add Renesas SH-Mobile LCDC
bindings
Hi Geert,
Thank you for the patch.
On Thu, Jun 22, 2023 at 11:21:13AM +0200, Geert Uytterhoeven wrote:
> Add device tree bindings for the LCD Controller (LCDC) found in Renesas
> SuperH SH-Mobile and ARM SH/R-Mobile SOCs.
>
> Based on a plain text prototype by Laurent Pinchart.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: Conor Dooley <conor+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> ---
> Changes compared to Laurent's original:
> - Convert to json-schema,
> - Rename compatible values from "renesas,lcdc-<SoC>" to
> "renesas,<SoC>-lcdc",
> - Add power-domains property,
> - Add MIPI-DSI port on SH-Mobile AG5,
> - Update example to reflect reality,
> - Add to MAINTAINERS.
> ---
> .../display/renesas,shmobile-lcdc.yaml | 108 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 109 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/renesas,shmobile-lcdc.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,shmobile-lcdc.yaml b/Documentation/devicetree/bindings/display/renesas,shmobile-lcdc.yaml
> new file mode 100644
> index 0000000000000000..72a39fce7294d56d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/renesas,shmobile-lcdc.yaml
> @@ -0,0 +1,108 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/renesas,shmobile-lcdc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas SH-Mobile LCD Controller (LCDC)
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
I'd be happy if you co-maintained this with me :-) Or even took
ownership completely.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,r8a7740-lcdc # R-Mobile A1
> + - renesas,sh73a0-lcdc # SH-Mobile AG5
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 1
> + maxItems: 5
> + description:
> + Only the functional clock is mandatory.
> + Some of the optional clocks are model-dependent (e.g. "video" (a.k.a.
> + "vou" or "dv_clk") is available on R-Mobile A1 only).
> +
> + clock-names:
> + minItems: 1
> + maxItems: 5
> + items:
> + enum: [ fck, media, lclk, hdmi, video ]
Switching to per-item descriptions would allow documenting which clock
applies to which SoC.
Are enum items unique by default ?
This would allow a combination of clocks that doesn't include the fck
clock, that's not right.
> +
> + power-domains:
> + maxItems: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: |
> + The connections to the output video ports are modeled using the OF graph
> + bindings specified in Documentation/devicetree/bindings/graph.txt.
it's available in YAML form now. I'd just drop the "specified in ...".
> + The number of ports and their assignment are model-dependent.
> + Each port shall have a single endpoint.
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: LCD port (R-Mobile A1 and SH-Mobile AG5)
> + unevaluatedProperties: false
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: HDMI port (R-Mobile A1 LCDC1 and SH-Mobile AG5)
> + unevaluatedProperties: false
> +
> + port@2:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: MIPI-DSI port (SH-Mobile AG5)
> + unevaluatedProperties: false
Let's condition the ports on the compatible value to enable automatic
validation.
> +
> + required:
> + - port@0
Based on the above, port@1 is required too as it's present on all
supported SoCs. Let's condition this on the compatible value too.
> +
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - power-domains
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/r8a7740-clock.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + lcdc0: lcd-controller@...40000 {
> + compatible = "renesas,r8a7740-lcdc";
> + reg = <0xfe940000 0x4000>;
> + interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp1_clks R8A7740_CLK_LCDC0>,
> + <&cpg_clocks R8A7740_CLK_M3>, <&lcdlclk0_clk>,
> + <&vou_clk>;
> + clock-names = "fck", "media", "lclk", "video";
> + power-domains = <&pd_a4lc>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + lcdc0_rgb: endpoint {
> + };
> + };
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 83e9f4ac6bedaa9f..dc1935c196cb0e0b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7023,6 +7023,7 @@ F: Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml
> F: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
> F: Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml
> F: Documentation/devicetree/bindings/display/renesas,du.yaml
> +F: Documentation/devicetree/bindings/display/renesas,shmobile-lcdc.yaml
> F: drivers/gpu/drm/renesas/
> F: include/linux/platform_data/shmob_drm.h
>
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists