linux-kernel - [PATCH] mm: Fix sparse warnings in backing-dev.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2023 18:07:37 +0100
From:   "Matthew Wilcox (Oracle)" <willy@...radead.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: [PATCH] mm: Fix sparse warnings in backing-dev.h

Sparse reports a context imbalance, and indeed _begin() returns
with the RCU lock held and _end() releases it.  Reassure sparse that
this is fine by adding appropriate annotations.

Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
---
 include/linux/backing-dev.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index fbad4fcd408e..69bb13412a3e 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -284,8 +284,9 @@ static inline struct bdi_writeback *inode_to_wb_wbc(
  * can't sleep during the transaction.  IRQs may or may not be disabled on
  * return.
  */
-static inline struct bdi_writeback *
-unlocked_inode_to_wb_begin(struct inode *inode, struct wb_lock_cookie *cookie)
+static inline
+struct bdi_writeback *unlocked_inode_to_wb_begin(struct inode *inode,
+		struct wb_lock_cookie *cookie) __acquires(RCU)
 {
 	rcu_read_lock();
 
@@ -311,7 +312,7 @@ unlocked_inode_to_wb_begin(struct inode *inode, struct wb_lock_cookie *cookie)
  * @cookie: @cookie from unlocked_inode_to_wb_begin()
  */
 static inline void unlocked_inode_to_wb_end(struct inode *inode,
-					    struct wb_lock_cookie *cookie)
+		struct wb_lock_cookie *cookie) __releases(RCU)
 {
 	if (unlikely(cookie->locked))
 		xa_unlock_irqrestore(&inode->i_mapping->i_pages, cookie->flags);
-- 
2.39.2