linux-kernel - Re: [PATCH] cpufreq: qcom-cpufreq-hw: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230623170856.GA1736857@hu-bjorande-lv.qualcomm.com>
Date:   Fri, 23 Jun 2023 10:08:56 -0700
From:   Bjorn Andersson <quic_bjorande@...cinc.com>
To:     Andrew Halaney <ahalaney@...hat.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <viresh.kumar@...aro.org>,
        <rafael@...nel.org>, <konrad.dybcio@...aro.org>,
        <andersson@...nel.org>, <agross@...nel.org>
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Use dev_err_probe() when
 failing to get icc paths

On Fri, Jun 23, 2023 at 10:57:07AM -0500, Andrew Halaney wrote:
> This way, if there's an issue (in this case a -EPROBE_DEFER), you can
> get useful output:
> 
>     [root@...p19-243-150 ~]# cat /sys/kernel/debug/devices_deferred
>     18591000.cpufreq        qcom-cpufreq-hw: Failed to find icc paths
> 
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>

Reviewed-by: Bjorn Andersson <quic_bjorande@...cinc.com>

Regards,
Bjorn

> ---
>  drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
> index a78d7a27b4b5..f2830371d25f 100644
> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
> @@ -661,7 +661,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev)
>  
>  	ret = dev_pm_opp_of_find_icc_paths(cpu_dev, NULL);
>  	if (ret)
> -		return ret;
> +		return dev_err_probe(dev, ret, "Failed to find icc paths\n");
>  
>  	for (num_domains = 0; num_domains < MAX_FREQ_DOMAINS; num_domains++)
>  		if (!platform_get_resource(pdev, IORESOURCE_MEM, num_domains))
> -- 
> 2.40.1
>