[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230623171031.GJ2112@pendragon.ideasonboard.com>
Date: Fri, 23 Jun 2023 20:10:31 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Thomas Zimmermann <tzimmermann@...e.de>,
Magnus Damm <magnus.damm@...il.com>,
dri-devel@...ts.freedesktop.org, linux-renesas-soc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 32/39] drm: renesas: shmobile: Shutdown the display on
remove
Hi Geert,
Thank you for the patch.
On Thu, Jun 22, 2023 at 11:21:44AM +0200, Geert Uytterhoeven wrote:
> When the device is unbound from the driver, the display may be active.
> Make sure it gets shut down.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c
> index a29c0c1093725b6e..636f1888b815579b 100644
> --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c
> +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c
> @@ -16,6 +16,7 @@
> #include <linux/pm_runtime.h>
> #include <linux/slab.h>
>
> +#include <drm/drm_crtc_helper.h>
> #include <drm/drm_drv.h>
> #include <drm/drm_fbdev_generic.h>
> #include <drm/drm_gem_dma_helper.h>
> @@ -145,6 +146,7 @@ static int shmob_drm_remove(struct platform_device *pdev)
> struct drm_device *ddev = &sdev->ddev;
>
> drm_dev_unregister(ddev);
> + drm_helper_force_disable_all(ddev);
I assume this will be turned into drm_atomic_helper_shutdown() later.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> drm_kms_helper_poll_fini(ddev);
> return 0;
> }
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists