linux-kernel - Re: [PATCH] spi: dt-bindings: atmel,at91rm9200-spi: fix broken sam9x7 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230624-embassy-scuff-9fdc0f150d1a@spud>
Date:   Sat, 24 Jun 2023 10:28:22 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Tudor Ambarus <tudor.ambarus@...aro.org>,
        Varshini Rajendran <varshini.rajendran@...rochip.com>,
        linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: dt-bindings: atmel,at91rm9200-spi: fix broken
 sam9x7 compatible

On Sat, Jun 24, 2023 at 10:20:54AM +0200, Krzysztof Kozlowski wrote:
> Commit a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7
> compatible") adding sam9x7 compatible did not make any sense as it added
> new compatible into middle of existing compatible list.  The intention
> was probably to add new set of compatibles with sam9x7 as first one.
> 
> Fixes: a3eb95484f27 ("spi: dt-bindings: atmel,at91rm9200-spi: add sam9x7 compatible")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

@Varshini, this is the template to follow for the rest of the series. I
know there's a lot of complaints while running dtbs_check for the entire
directory, but you can isolate things to a singular binding and check
the dts against it using:
make dtbs_check DT_SCHEMA_FILES=atmel,at91rm9200-spi.yaml
That should make it easier to see that you don't break existing dts by
modifying the binding.

Cheers,
Conor.

> ---
>  .../devicetree/bindings/spi/atmel,at91rm9200-spi.yaml          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> index bdc42eeacba4..58367587bfbc 100644
> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml
> @@ -19,7 +19,10 @@ properties:
>        - const: atmel,at91rm9200-spi
>        - items:
>            - const: microchip,sam9x60-spi
> +          - const: atmel,at91rm9200-spi
> +      - items:
>            - const: microchip,sam9x7-spi
> +          - const: microchip,sam9x60-spi
>            - const: atmel,at91rm9200-spi
>  
>    reg:
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)