linux-kernel - Re: [PATCH] bus: ixp4xx: fix IXP4XX_EXP_T1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbW_V_1RtYy1+KRXTMe5E4g2vDvcR7Y9f2O4C=XLnUaXg@mail.gmail.com>
Date:   Sat, 24 Jun 2023 14:20:30 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jonas Gorski <jonas.gorski@...il.com>
Cc:     Imre Kaloz <kaloz@...e.hu>, Krzysztof Halasa <khalasa@...p.pl>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: ixp4xx: fix IXP4XX_EXP_T1_MASK

On Sat, Jun 24, 2023 at 1:30 PM Jonas Gorski <jonas.gorski@...il.com> wrote:

> The IXP4XX_EXP_T1_MASK was shifted one bit to the right, overlapping
> IXP4XX_EXP_T2_MASK and leaving bit 29 unused. The offset being wrong is
> also confirmed at least by the datasheet of IXP45X/46X [1].
>
> Fix this by aligning it to IXP4XX_EXP_T1_SHIFT.
>
> [1] https://www.intel.com/content/dam/www/public/us/en/documents/manuals/ixp45x-ixp46x-developers-manual.pdf
>
> Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus")
> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>

Yups that's a bug! (My typo...)

I'll funnel it upstream through the SoC tree.

Yours,
Linus Walleij