linux-kernel - Re: [PATCH v5 4/4] perf tools: Add printing perf_event_attr config symbol in perf_event_attr_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2654189b-0804-305a-be06-3234f39f0403@huawei.com>
Date:   Sun, 25 Jun 2023 09:38:27 +0800
From:   Yang Jihong <yangjihong1@...wei.com>
To:     Namhyung Kim <namhyung@...nel.org>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...nel.org>, <irogers@...gle.com>,
        <adrian.hunter@...el.com>, <anshuman.khandual@....com>,
        <jesussanp@...gle.com>, <linux-perf-users@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 4/4] perf tools: Add printing perf_event_attr config
 symbol in perf_event_attr__fprintf()

Hello,

On 2023/6/24 13:28, Namhyung Kim wrote:
> Hello,
> 
> On Thu, Jun 22, 2023 at 10:46 PM Yang Jihong <yangjihong1@...wei.com> wrote:
>>
>> When printing perf_event_attr, always display perf_event_attr config and
>> its symbol to improve the readability of debugging information.
>>
> 
> [SNIP]
>> +
>> +#ifdef HAVE_LIBTRACEEVENT
>> +static void __p_config_tracepoint_id(char *buf, size_t size, u64 value)
>> +{
>> +       char *str = tracepoint_id_to_name(value);
> 
> This makes the python module import test failing due to the
> undefined symbol.  I'll fix it by adding a dummy function in
> util/python.c file.  But next time, please run `perf test` first
> and make sure you don't break anything.

Thanks for the correction.

Running `perf test` on my environment has only one testcase for python:

19:'import perf' in python: Ok

The result is OK. The possible cause is that some libraries are missing 
in my environment. As a result, other Python tests are not executed. 
I'll check them first.

Thanks,
Yang