[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <907bbe2d-9cbf-480c-be57-3289d113c42a@huaweicloud.com>
Date: Sun, 25 Jun 2023 17:22:08 +0800
From: Li Nan <linan666@...weicloud.com>
To: Ashok Raj <ashok_raj@...ux.intel.com>, linan666@...weicloud.com
Cc: axboe@...nel.dk, dan.j.williams@...el.com,
vishal.l.verma@...el.com, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, yukuai3@...wei.com,
yi.zhang@...wei.com, houtao1@...wei.com, yangerkun@...wei.com,
Ashok Raj <ashok.raj@...el.com>, linan122@...wei.com
Subject: Re: [PATCH v3 4/4] block/badblocks: fix the bug of reverse order
在 2023/6/21 22:15, Ashok Raj 写道:
> On Thu, Jun 22, 2023 at 01:20:52AM +0800, linan666@...weicloud.com wrote:
>> From: Li Nan <linan122@...wei.com>
>>
>> Order of badblocks will be reversed if we set a large area at once. 'hi'
>> remains unchanged while adding continuous badblocks is wrong, the next
>> setting is greater than 'hi', it should be added to the next position.
>> Let 'hi' +1 each cycle.
>
> The commitlog needs more work.
OK, I will improve this.
>>
>> # echo 0 2048 > bad_blocks
>> # cat bad_blocks
>> 1536 512
>> 1024 512
>> 512 512
>> 0 512
>
> Is the above before or after this patch is applied?
All badblocks are arranged from small to large. after patch:
# cat bad_blocks
0 512
512 512
1024 512
1536 512
I will show it in next version. Thanks for your suggestion.
>
>>
>> Fixes: 9e0e252a048b ("badblocks: Add core badblock management code")
>> Signed-off-by: Li Nan <linan122@...wei.com>
>> ---
>> block/badblocks.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/block/badblocks.c b/block/badblocks.c
>> index 2c2ef8284a3f..3b816690b940 100644
>> --- a/block/badblocks.c
>> +++ b/block/badblocks.c
>> @@ -301,6 +301,7 @@ int badblocks_set(struct badblocks *bb, sector_t s, int sectors,
>> p[hi] = BB_MAKE(s, this_sectors, acknowledged);
>> sectors -= this_sectors;
>> s += this_sectors;
>> + hi++;
>> changed = true;
>> }
>> }
>> --
>> 2.39.2
>>
>
> .
--
Thanks,
Nan
Powered by blists - more mailing lists