linux-kernel - Re: [PATCH v5 1/4] dt-bindings: arm: amlogic: add Amlogic A311D2 bindings

Open Source and information security mailing list archives

Date:   Sun, 25 Jun 2023 18:43:50 +0800
From:   Kelvin Zhang <kelvin.zhang@...ogic.com>
To:     Lucas Tanure <tanure@...ux.com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>
Cc:     Nick <nick@...das.com>, Artem <art@...das.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: arm: amlogic: add Amlogic A311D2
 bindings

> Add bindings for the Khadas Vim4 board, using A311D2 soc, a Meson T7
> family chip.
> 
> Signed-off-by: Lucas Tanure <tanure@...ux.com>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>   Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 274ee0890312..8dbd65170c50 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -211,6 +211,13 @@ properties:
>                 - amlogic,aq222
>             - const: amlogic,s4
> 
> +      - description: Boards with the Amlogic Meson t7 A311D2 SoC

Lucas,
Based on the previous discussion, I strongly suggest dropping "Meson".
T7 is designed for smart display, which does not belong to old Meson series.
You can refer to S4.
Also, t7 -> T7.
Thanks!

> +        items:
> +          - enum:
> +              - khadas,vim4
> +          - const: amlogic,a311d2
> +          - const: amlogic,t7
> +
>   additionalProperties: true
> 
>   ...
> --
> 2.41.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives