linux-kernel - RE: [PATCH 4/4] arm64: dts: imx93: enable CM33 for 11x11 EVK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DU0PR04MB9417A0C5546DFCB0F34516FA8821A@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date:   Sun, 25 Jun 2023 11:23:30 +0000
From:   Peng Fan <peng.fan@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/4] arm64: dts: imx93: enable CM33 for 11x11 EVK

> Subject: Re: [PATCH 4/4] arm64: dts: imx93: enable CM33 for 11x11 EVK
> 
> On 25/06/2023 12:55, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > Add reserved memory node for rpmsg
> > Enable CM33 node with mailbox property included for doorbell.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> 
> ...
> 
> >  	};
> >
> >  	reg_vref_1v8: regulator-adc-vref {
> > @@ -107,6 +139,16 @@ &lpuart1 { /* console */
> >  	status = "okay";
> >  };
> >
> > +&{/remoteproc-cm33} {
> 
> That's not proper reference by label.

Ok, will give it a true lable, such as "cm33"
> 
> > +	mbox-names = "tx", "rx", "rxdb";
> > +	mboxes = <&mu1 0 1
> > +		  &mu1 1 1
> > +		  &mu1 3 1>;
> 
> Three entries, not one. Anyway, why mboxes depend on the board? This is
> quite surprising.

The m33 firmware delivered by NXP use MU1 for doorbell, but others may
use other MUs, or even not use MUs. So I put it in board dts just for
NXP boards.

Thanks,
Peng.

> 
> Best regards,
> Krzysztof